Show hidden map if it's requested by URL wtracks?map=...
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only shown transiently: * since right now map is remembered, it will still be shown on next refresh (could be changed) * but as soon as user changes it, it will be hidden again
Behaviour on refresh and for hidden overlays is similar as for `?map`... ... except there is a preexisting issue right now where enabled overlays are not shown on refresh, but they are in the shared URL. Examples: - Multi: http://localhost:8000/?map=OpenStreetMap&overlays=Hills,Cycling - Hidden: http://localhost:8000/?map=OpenStreetMap&overlays=FR%20IGN%20Parcelles Part of opoto#26
|
Good, thanks! |
eddy-geek
added a commit
to eddy-geek/wtracks
that referenced
this pull request
Dec 25, 2021
opoto
added a commit
that referenced
this pull request
Dec 25, 2021
Fix overlays restore (regression from #27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
Show hidden map if it's requested by URL
wtracks?map=...It is only shown transiently:
?mapparam is stored inwt.baseLayer, it will still be shown on next refresh (could be changed I guess)wt.mymapsis not changed)Commit 2
Add ?overlays request parameter to control overlays
Behaviour on refresh and for hidden overlays is similar as for
?map...... except I think there is a preexisting issue right now where enabled overlays are not shown on refresh, but they are in the shared URL.
Examples:
Cc #26